The clocks turn back an hour in California at 3am on Nov 5th.
Some Manifold things are in local time in California. Will we see any bugs plausibly caused by this?
As a bug may not have a clear cause, at least not knowable by me, this may be a judgement call.
Things that are different-but-not-really-bugs won't count, such as retroactive changes to daily statistics due to using 24-hour periods in a different timezone (this won't actually happen until 180 days later, but that's the sort of thing I'm talking about). Has to be something actually affecting users in some negative way, the site working obviously not as intended. Stuff that just happens at a different time, when that time was arbitrary anyway, won't count. Again that might be a judgement call. I won't bet.
I'll wait until market close roughly a week after the clocks turn back for any bugs to surface.
1,000🏅 Top traders
| # | Trader | Total profit |
|---|---|---|
| 1 | Ṁ8 | |
| 2 | Ṁ7 | |
| 3 | Ṁ7 | |
| 4 | Ṁ5 | |
| 5 | Ṁ4 |
@chrisjbillington League user details,"mana earned profit" display seems to include all trades made after 07:00 UTC on the 1st but the display of all trades/markets below only includes trades starting at 08:00 UTC on the 1st. So it is not clear which one is right and which is wrong. For me, it is a difference of (currently) 152 mana, but for someone else it could mean the difference between promotion and demotion!
(The bug is that they are Different, since either option would have been a fair choice to make... choosing two start times is obviously wrong though.)
@Eliza Interesting. From common/src/leagues.ts, it looks like leagues start is supposed to be midnight UTC-7, i.e. 07:00 UTC.
I'm seeing the browser getting bets to calculate per-market profits using 06:00 though, not 08:00. Is what I see there different again to what you see? Or are you seeing 06:00 UTC and wrote 08:00 in error?
Here's the request my browser makes:
If I check my code from the other day when I copied this out of my browser to reproduce the calculation myself, it was also 06:00 UTC then (for the start of season 7).
(maybe it's fetching bets from 06:00 UTC but then there's some further filtering that excludes bets before 08:00 UTC? Are you inferring the 08:00 cutoff from bets that are missing, or from looking at query params?)
@chrisjbillington I noticed my bets from 07:00-07:10 on the market "Who will win the 2024 Tour Down Under" were missing from the leagues bet display. My browser at the time was sending that request with 08:00 instead of yours showing 06:00. This market/bets still do not show up on my browser when I go to Leagues and look at myself.
@Eliza Maybe yours is ALSO wrong due to time zone shifting but in the opposite direction?
That is, something to do with the local time zone of the user...just a thought for why yours might be 06:00 instead of 08:00
@Eliza Maybe. When I view your leagues bets, as expected, I see those bets that are missing for you, and more. 6pm in my timezone is 07:00 UTC, so I'm seeing bets from 06:59 UTC, before the official leagues start, lol.
Might try changing my computer's timezone and see if anything changes. I'm in Australian Eastern Daylight Time. What timezone are you in?
@Eliza Fascinating. So here's what I get changing my computer's timezone:
With my computer set to AEDT (UTC+11), I see requests for bets after 06:00 UTC
With my computer set to to US CST (UTC-6), I see requests for bets after 08:00 UTC, as you're seeing.
With my computer set to ACDT (UTC+10:30, I thought the half-hour difference would stick out like a sore thumb and distinguish the issue from other off-by-one errors), I still see requests for bets after 06:00 UTC.
If I set my computer's timezone to Solomon Islands Time (also UTC+11, like AEDT, but doesn't observe daylight savings), then I see requests fetching bets after 07:00 UTC!
This makes me think the bug is something to do with whether your current timezone (in the sense of the location, not the UTC offset) is in daylight savings or not, but the picture isn't totally clear since both Solomon Islands time and US CST are not in daylight savings, yet they give different results.
Edit: unless there's some code somewhere like "if in daylight savings, shift one hour that way, if in a jurisdiction that observes daylight savings but is currently in standard time, shift one hour the other way, if in a jurisdiction that doesn't observe daylight savings, don't shift"
@Eliza Figured it out! Made a bug report:
https://github.com/manifoldmarkets/manifold/issues/2242
It's because the code adds an integer number of months to the season 1 start time to get the start time of the current season - but the length of a month is timezone dependent! Your November was an hour longer than a multiple of 24h, and my October an hour shorter. So the addition of a month needs to be done in UTC, not in your local timezone.
Interesting kind of bug.
(doesn't affect this market, I wasn't intending to re-resolve if something came up later, though I could have made this more explicit)
@chrisjbillington Amazing! I didn't expect the market to re-resolve, just laughed and put my comment here when I noticed this because it was so goofy.
@chrisjbillington Trying to figure out an appropriate amount to hedge that the streak will re-reset and get double incremented within 1 day.
@Eliza I guess that would not be a negative way....unless it cost users two streak forgiveness points....
@Eliza Oh, if streaks already reset, did anyone lose their streak 1 hour early? That would be negative.
@Eliza Interesting. I can certainly check if there were any users that placed bets in the last hour of the day that hadn't placed bets earlier in the day. There are probably some.
Having said that, the time that streaks reset is arbitrary. For me it's sometimes 6pm, sometimes 5pm, and sometimes 7pm, depending on the various possibilities of when I'm in DST and CA is in DST. So I'm leaning away from saying it should resolve if someone lost their streak. Someone in CA may have been banking on it, but the rest of us in other timezones have never been able to assume calendar day equals streak-relevant interval anyway.
@chrisjbillington It looks like the UI display is only a visual thing and would not affect the streak:
https://github.com/manifoldmarkets/manifold/blob/74ab5cae775da6c48a07d35c5e894715fbb795a5/web/components/profile/betting-streak-modal.tsx
@Eliza Scratch that, the betting streak reset is hard coded to 7 UTC:
https://github.com/manifoldmarkets/manifold/blob/main/common/src/economy.ts#L49
Anyone who thought they could reset their betting streak at 11:30pm Pacific will lose their streak. The new time will be 11pm Pacific unless this is changed. I think?